Provide settings to control multifilter initial selection

[kewisch]

What type of PR is this? (check all applicable)

• Feature

Description

Back in #608 there was a hidden feature to pre-select all entries in a multi-filter, which got removed when migrating the filters to react. I heavily depend on this and would like to see it come back. I think it would make sense to fix this in a less hacky way, using column metadata.

In below screenshot, the priority and status columns are multi-filters, therefore they have an extra dropdown to select one of "first", "all", or "none". Selecting "first" uses the current behavior to select the first value, "all" and "none" are self-explanatory.

To-Do

• Possibly refactor filter current value
• Find sensible defaults for dashboard-level filters
• Tests

Discussion items

I'm not particularly happy about how setFilterDefaults runs after the filters are gathered in the query result service and after the options are retrieved. Changing this may require some refactoring, but before I start with that I'd like to get some feedback

The second thing that will require some discussion, how to do dashboard level filters. These don't have access to a specific visualization, so if two visualizations have different defaults for the default state for a multi-filter column then there is a conflict. Also, it doesn't seem like the specific visualizations are available at the time the filters are determined, similar to the first discussion point.

Looking forward to your thoughts.

Related Tickets & Documents

TBD

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

[cypress]

---

Test summary

58 • 5 • 0 • 0

---

Run details

Commit	09481db
Started	Jun 16, 2019 9:04 PM
Ended	Jun 16, 2019 9:13 PM
Duration	09:23 💡
OS	linux Debian - 8.10
Browser	Electron 61.0.3163.100

View run in Cypress Dashboard ➡️

---

Failures

client/cypress/integration/visualizations/edit_visualization_dialog_spec.js ⏯		1
1	Edit visualization dialog > opens New Visualization dialog	💻
client/cypress/integration/visualizations/pivot_spec.js ⏯		2
1	Pivot > creates Pivot with controls	💻
2	Pivot > creates Pivot without controls	💻
client/cypress/integration/visualizations/sankey_sunburst_spec.js ⏯		2
1	Sankey and Sunburst > creates Sunburst	💻
2	Sankey and Sunburst > creates Sankey	💻

---

This comment has been generated by cypress-bot as a result of your project's GitHub integration settings. You can manage this integration in your project's settings in the Cypress Dashboard

[arikfr]

Thank you for taking a stab at this, @kewisch. It seems that this is local to a specific table visualization, but filters are at the query level (i.e. same filters apply to all the visualizations of the same query). It's also unclear how this will work on dashboards.

We been doing a lot of work on improving parameters and I wonder if you could replace your use of filters with parameters once they support multi-select? (#3952)

[arikfr]

@kewisch did you see my previous comment?

[kewisch]

Hi @arikfr sorry for the delay. I think a lot of this can be covered by the multi-value query filter, possibly with some small features in addition. I've checked the gifs and it seems possible to add multiple values either based on a string list or a query. This is a great start and would allow me to replicate what filters can do now.

What I am missing, apologies if I missed this, is a feature that would auto-select all values in the multi-select when the query is executed. Is this something possible with #3952 ?

[arikfr]

What I am missing, apologies if I missed this, is a feature that would auto-select all values in the multi-select when the query is executed. Is this something possible with #3952 ?

Not at the moment.