Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'connection_source' property in presto query runner #3938

Closed
wants to merge 2 commits into from

Conversation

iamhongri
Copy link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

  • Add 'connection_source' property in presto query runner

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@guidopetri
Copy link
Contributor

@iamhongri , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts?

We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that.

@justinclift
Copy link
Member

The resolve conflicts in this PR look like they were mostly due to differing formatting, so I just manually reformatted those a bit differently. Hopefully got it right.

This PR looks like it's never been reviewed though, so even if it passes CI now it'll still need to be looked over properly.

@justinclift
Copy link
Member

Ahhh. Looks like I didn't get the reformatting correct enough for black --check to be happy with. 😦

@justinclift
Copy link
Member

@iamhongri This should be super easy to fix, if you're interested in it still. 😄

@guidopetri guidopetri self-assigned this Jul 29, 2023
@guidopetri
Copy link
Contributor

Closing due to lack of activity. Feel free to reopen if you want to come back to this PR!

@guidopetri guidopetri closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants