Fix: Details Visualization: render date/time values as strings and not epoch time #3951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kravets-levko
approved these changes
Jul 4, 2019
| }; | ||
|
|
||
| if (type === 'date' || type === 'datetime') { | ||
| if (moment.isMoment(value)) { |
There was a problem hiding this comment.
I think if (moment.isMoment(value)) { is enough, previous if is almost useless.
There was a problem hiding this comment.
It's relevant to make sure we have a known format type. But it's true that it will only be a moment if it's one of those (in normal situations).
I agree. I think it will make sense to reuse parts of the Table editor and rendering here, we can look into this when migrating the Table editor. Although wouldn't want to delay it because of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Because we were just converting values to strings (
'' + value) date/time values were rendered as epoch times:This Pull Request fixes this by properly converting them using the system settings date/time format.
There is some logic duplication here with the Table visualization, which we should remove in the future.