Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotly legent overlaps plot on small screens (when legend clicked) #3976

Merged
merged 1 commit into from
Jul 13, 2019

Conversation

kravets-levko
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Revert changes from #3882 and apply a new fix. Previous time I misunderstood the problem and applied a wrong fix, but the real problem was with the code that detects CSS support.

Related Tickets & Documents

Fixes #3975

@justinclift
Copy link
Member

Awesome @kravets-levko. I'll this out in a test instance later today (~10 hrs away), to confirm it solves the problem. 😄

@arikfr
Copy link
Member

arikfr commented Jul 13, 2019 via email

Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the technical parts (not into JS), but this does fix the problem when testing it with both Chrome and Firefox in a local VM. 😄

@justinclift
Copy link
Member

justinclift commented Jul 13, 2019

Justin, are you familiar with the preview deployments?

Ahhh. Thus the deploy/netlify - Deploy preview ready thing in the list below. That'll save time in future. 😄

Testing with both Chrome 75 (Win7) and Firefox 68 (Linux) on that Preview instance... the problem is fixed.

@kravets-levko kravets-levko merged commit 4e9da3f into master Jul 13, 2019
@kravets-levko kravets-levko deleted the fix/plotly-legend-on-small-screens-2 branch July 13, 2019 15:28
@arikfr
Copy link
Member

arikfr commented Jul 14, 2019

@justinclift

Ahhh. Thus the deploy/netlify - Deploy preview ready thing in the list below. That'll save time in future. 😄

Exactly. For every PR, Netlify creates a deployment. This allows testing only the frontend (they all use the same backend), but in many cases it's enough.

harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legend overlaps plot on small screens
3 participants