Alert redesign #2 - Destinations #4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
force-pushed
the
alert-2-destinations
branch
from
0917d56 to
8d9587a
Compare
kravets-levko
approved these changes
Sep 24, 2019
| }; | ||
|
|
||
| export default function init(ngModule) { |
ranbena
force-pushed
the
alert-2-destinations
branch
from
97e0a89 to
519dc34
Compare
ranbena
force-pushed
the
alert-2-destinations
branch
from
519dc34 to
7740deb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #4153, adding redesigned alert destinations.
Description
Adds Alert Destinations to Alert view page.
Clicking "+ Add" opens the
SelectItemsDialogwhich is redesigned in #4157.Email config error was before an alert at the top, but now a warning icon in context.
Before:
After:
This also resulted in a visual change to the user profile page alert:
Tests were made to assure permission related logic.