Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some style adjustments #4162

Merged

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Sep 21, 2019

Stying fixes for this feature.

@ranbena ranbena self-assigned this Sep 21, 2019
@gabrieldutra gabrieldutra merged commit df4d9cf into getredash:ds-advanced-options Sep 22, 2019
@gabrieldutra
Copy link
Member

Thanks, @ranbena 😁

arikfr pushed a commit that referenced this pull request Oct 6, 2019
…#4160)

* DynamicForm support for advanced options

* Randomly select a few options to be advanced

* Merge conditions with the same logic

* Address some comments

* Update styling for the button

* Some style adjustments (#4162)

* Don't set default value to additional settings

* Rename advanced -> extra

* Show extra fields by default when they are filled

* Update hasFilledExtraField logic

* Add example field from destination as extra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants