Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented new condition comparison options #4240

Merged
merged 3 commits into from
Oct 15, 2019
Merged

Implemented new condition comparison options #4240

merged 3 commits into from
Oct 15, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Oct 12, 2019

  • Feature

Description

Front end complimentary implementation for #4134.

Related Tickets & Documents

#4132

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

pic

@ranbena ranbena self-assigned this Oct 12, 2019
@ranbena ranbena requested a review from kravets-levko October 12, 2019 16:33
Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice 👍

P.S. I moved the backward compatibility code to Alert service - I think it's better place for it. I hope you don't mind that I did it directly in this PR 🙇‍♂️

@ranbena
Copy link
Contributor Author

ranbena commented Oct 14, 2019

Thanks Levko it really is a better place for it. But my Proxy 😭

@arikfr arikfr merged commit 53d971b into master Oct 15, 2019
@arikfr arikfr deleted the alert-ops branch October 15, 2019 05:41
@ranbena ranbena mentioned this pull request Oct 17, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants