-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Cohort visualization to React #4270
Conversation
130aa5b
to
5ebf982
Compare
Hi @kravets-levko, Very nice changes. While you are at it, I have two suggestions.
|
Hi @deecay! Thank you for a feedback.
"People" is an accidental bug (I was working late night yesterday 😴) - restored "Users". Actually, as you may notice, I prepare a ground for more configuration options for this visualizations (like changing titles, labels, value formats, colors) - they're now supported in rendering engine, but not available in UI yet because I don't want to introduce too much changes and new features in this PR.
That was also leftover after some experiments - restored previous behavior: |
@kravets-levko Nice. Thanks. |
👍 |
What type of PR is this? (check all applicable)
Description
chroma-js
)numeral
(no editor options for now)moment
for date formatting and manipulations + remove hard-coded month namesRelated Tickets & Documents
#3301 (Migrate Visualizations to React -> Cohort)
Fixes #4329
Mobile & Desktop Screenshots/Recordings (if there are UI changes)