Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracted alert menu button #4273

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Extracted alert menu button #4273

merged 2 commits into from
Oct 22, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Oct 22, 2019 •
edited
Loading

  • Refactor

Description

  1. Deduped the delete menu by supplying <MenuButton /> to AlertView and AlertEdit.
  2. Added menu button "loading" state.

There is no change in functionality.
This is a preparation for alert on/off toggle feature.

Screenshots

@ranbena ranbena marked this pull request as ready for review October 22, 2019 09:06
@ranbena ranbena requested a review from kravets-levko October 22, 2019 09:06
@ranbena ranbena self-assigned this Oct 22, 2019
kravets-levko
kravets-levko approved these changes Oct 22, 2019
View reviewed changes
Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

client/app/pages/alert/components/MenuButton.jsx Outdated Show resolved Hide resolved
@ranbena ranbena merged commit 3dfad87 into master Oct 22, 2019
@weekly-digest weekly-digest bot mentioned this pull request Oct 28, 2019
Closed
@guidopetri guidopetri deleted the alert-menu-button branch July 22, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kravets-levko kravets-levko kravets-levko approved these changes

Assignees

@ranbena ranbena

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ranbena @kravets-levko