Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dremio driver #4309

Closed

Conversation

Rodrigonavarro23
Copy link

What type of PR is this? (check all applicable)

  • New Query Runner (Data Source)

Description

Add Dremio as datasource.

"Dremio delivers lightning-fast queries and a self-service semantic layer directly on your data lake storage. No moving data to proprietary data warehouses, no cubes, no aggregation tables or extracts. Just flexibility and control for data architects, and self-service for data consumers."

In order to be able to use Dremio, I had to import pyodbc into the requirements and alien as dependency on the docker file, it is still necessary to install the driver on the machine, here I leave an example of installation in docker with Ubuntu image:

# install Dremio driver
ENV DRIVER_VERSION=1.4.2.1003
RUN wget "https://download.dremio.com/odbc-driver/${DRIVER_VERSION}/dremio-odbc-${DRIVER_VERSION}-1.x86_64.rpm" -O /dremio-odbc-${DRIVER_VERSION}-1.x86_64.rpm
RUN alien -i --scripts /dremio-odbc-${DRIVER_VERSION}-1.x86_64.rpm
RUN rm -f /dremio-odbc-${DRIVER_VERSION}-1.x86_64.rpm

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Captura de Pantalla 2019-10-28 a la(s) 10 26 47
Captura de Pantalla 2019-10-28 a la(s) 10 26 55

Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Always happy to support more data sources.

Do you know if the Dremio ODBC driver has some license the end user needs to accept, like the Oracle one? Because we might just add it to the Docker image if it doesn't.

redash/query_runner/dremio.py Outdated Show resolved Hide resolved
redash/query_runner/dremio.py Show resolved Hide resolved
@Rodrigonavarro23
Copy link
Author

Thanks! Always happy to support more data sources.

Do you know if the Dremio ODBC driver has some license the end user needs to accept, like the Oracle one? Because we might just add it to the Docker image if it doesn't.

Is open license, I could installing directly into the docker image

@Rodrigonavarro23
Copy link
Author

Hi, there is something else pending for this PR?

@guidopetri
Copy link
Contributor

@Rodrigonavarro23 , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts?

We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that.

@justinclift
Copy link
Member

Looking at the Dremio website, it looks like they've switched to a different ODBC driver in the meantime:

https://www.dremio.com/drivers/odbc/

Apache Arrow Flight SQL is a modern open source protocol, co-created by Dremio, for querying SQL-based
systems such as databases, data warehouses, and data lakehouses.

So the download in the Dockerfile would need to be updated to match. The changes in the requirements*.txt files aren't needed any more either, as we already have pyodbc includes for other data sources. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants