-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dremio driver #4309
Add Dremio driver #4309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Always happy to support more data sources.
Do you know if the Dremio ODBC driver has some license the end user needs to accept, like the Oracle one? Because we might just add it to the Docker image if it doesn't.
Is open license, I could installing directly into the docker image |
Hi, there is something else pending for this PR? |
@Rodrigonavarro23 , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts? We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that. |
Looking at the Dremio website, it looks like they've switched to a different ODBC driver in the meantime: https://www.dremio.com/drivers/odbc/
So the download in the Dockerfile would need to be updated to match. The changes in the |
What type of PR is this? (check all applicable)
Description
Add Dremio as datasource.
In order to be able to use Dremio, I had to import pyodbc into the requirements and alien as dependency on the docker file, it is still necessary to install the driver on the machine, here I leave an example of installation in docker with Ubuntu image:
Mobile & Desktop Screenshots/Recordings (if there are UI changes)