Add user/pass authentication support for Druid #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Oct 29, 2019
Jakdaw
changed the title
|
Good points - also I've missed the requirements bump in the PR. Will fix shortly. |
|
Library treats None like no parameter being passed... empty string it doesn't.... so I guess I need to go look at how self.configuration is populated. |
|
Empty strings: in another connector facing a similar issue, to make sure empty strings are ignored I did: |
|
That's neat! |
Jakdaw
force-pushed
the
add-auth-for-druid
branch
from
9c62f5f to
8b7f635
Compare
Jakdaw
changed the title
|
Thanks! |
|
To overcome this issue in redash v8.0.0 you can add the username and password in the host field: |
|
@dlevison clever :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add support for user/password authentication when connecting to Druid.