-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TagsList and Sidebar to use Ant components #4338
Conversation
Awesome @gabrieldutra! 🎉 Is it possible to move that blue stripe (selected item indication) to left - as it was with Bootstrap styles? |
@kravets-levko I agree that with the current position of the sidebar the indication should be on the left side, but what if we moved the sidebar to the left side? 😮 |
I like current placement of sidebar, but, I think, @gabrieldutra may try both variants and then decide what looks better 👍 |
I like sidebar on right side more, but left side looks good as well 👍 |
I think the thinking behind putting the sidebar on the right side was:
Considering that both options look good, let's go with having it as is today and put the stripe in the right place (c21ecdf). |
This reverts commit 30b08b2.
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
What type of PR is this? (check all applicable)
Description
Following this discussion, this is an adaptation using Ant components for the Sidebar menu and the TagsList.
Initially this is to discuss the result and possible modifications from the Ant Components.
Related Tickets & Documents
--
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Queries List
![ant-tags-and-sidebar](https://user-images.githubusercontent.com/3356951/68159838-52414380-ff31-11e9-869f-a51c5221a4b4.gif)
Users List
![users-page](https://user-images.githubusercontent.com/3356951/68159854-59685180-ff31-11e9-89bb-001b2f6597fd.png)