Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TagsList and Sidebar to use Ant components #4338

Merged
merged 4 commits into from
Nov 7, 2019

Conversation

gabrieldutra
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor

Description

Following this discussion, this is an adaptation using Ant components for the Sidebar menu and the TagsList.

Initially this is to discuss the result and possible modifications from the Ant Components.

Related Tickets & Documents

--

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Queries List
ant-tags-and-sidebar

Users List
users-page

@gabrieldutra gabrieldutra self-assigned this Nov 4, 2019
@kravets-levko
Copy link
Collaborator

Awesome @gabrieldutra! 🎉

Is it possible to move that blue stripe (selected item indication) to left - as it was with Bootstrap styles?
image

@arikfr
Copy link
Member

arikfr commented Nov 5, 2019

@kravets-levko I agree that with the current position of the sidebar the indication should be on the left side, but what if we moved the sidebar to the left side? 😮

@kravets-levko
Copy link
Collaborator

I like current placement of sidebar, but, I think, @gabrieldutra may try both variants and then decide what looks better 👍

@gabrieldutra
Copy link
Member Author

gabrieldutra commented Nov 6, 2019

Inverted Stripe
inverted-stripe

Inverted Menu
inverted-menu

In general perspective, left-to-right readers will face the sidebar first when it's on the left side.

I liked the feeling when it was on the left side, but lmk what you prefer :)

@kravets-levko
Copy link
Collaborator

I like sidebar on right side more, but left side looks good as well 👍

@arikfr
Copy link
Member

arikfr commented Nov 7, 2019

I think the thinking behind putting the sidebar on the right side was:

  • It makes sense to show the main content (the list) first.
  • The sidebar isn't a menu but more like filters for the data shown (which is more common to have on the right).

Considering that both options look good, let's go with having it as is today and put the stripe in the right place (c21ecdf).

@gabrieldutra
Copy link
Member Author

Done!

Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gabrieldutra gabrieldutra merged commit 6716bb3 into master Nov 7, 2019
@gabrieldutra gabrieldutra deleted the ant-tags-and-sidebar branch November 7, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants