Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unicode encode error by column duplicate in presto datasource #4362

Closed

Conversation

elonlo
Copy link

@elonlo elonlo commented Nov 16, 2019

ex.
select '1' as "测试abc", '2' as "测试abc", '3' as "test_abc", '4' as "test_abc"
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-1: ordinal not in range(128)

ex.
select '1' as "测试abc", '2' as "测试abc", '3' as "test_abc", '4' as "test_abc"
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-1: ordinal not in range(128)
@arikfr
Copy link
Member

arikfr commented Nov 17, 2019

The master branch is using Python 3, so the u'' prefix is no longer needed there. You're welcome to add a test case for the fetch_columns method to verify this.

@elonlo
Copy link
Author

elonlo commented Nov 27, 2019

okay, i close pr

@elonlo elonlo closed this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants