Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dragged parameter wrapping in some cases #4415

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

gabrieldutra
Copy link
Member

@gabrieldutra gabrieldutra commented Dec 1, 2019

What type of PR is this? (check all applicable)

  • Bug Fix

Description

While checking the Preview I noticed this (avail here):

parameters-dragging-issue

The width: auto was removed in #4199 and it handles this, so I added it back (LMK if you think it deserves a comment on css)

Related Tickets & Documents

--

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

After:
parameters-dragging-fixed

Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it works (tested with all parameter types and different param names). Also, I noticed that adding white-space: nowrap; to .parameter-block (in the same file) also fixes the issue, but without !important modifier.

@gabrieldutra gabrieldutra force-pushed the parameters-dragged-width branch from 03c2ac1 to 467c918 Compare December 3, 2019 15:18
@gabrieldutra gabrieldutra merged commit c14e7ab into master Dec 3, 2019
@gabrieldutra gabrieldutra deleted the parameters-dragged-width branch December 3, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants