-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed visualizations become flex. #4422
Conversation
@gabrieldutra does this need any changes following the merge of the React version of the viz embed page? |
No, looks like it works post-merge without changes |
@shinsuke-nara , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts? We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that. |
The merge conflict looked pretty simple, so I just made a first attempt at resolving it. Lets see if our CI tests seem happy with things. |
Codecov Report
@@ Coverage Diff @@
## master #4422 +/- ##
=======================================
Coverage 59.71% 59.71%
=======================================
Files 151 151
Lines 12261 12261
Branches 1658 1658
=======================================
Hits 7322 7322
Misses 4733 4733
Partials 206 206 |
This looks like it was already reviewed when first submitted, so now that it's passing CI we might as well merge it. 😄 |
Co-authored-by: Shinsuke Nara <shinsuke.nara@muraoka-design.com> Co-authored-by: Justin Clift <justin@postgresql.org>
What type of PR is this? (check all applicable)
Description
Embed visualizations are not flex for vertical but I think they should be flex.
The reason is following
less
code:redash/client/app/assets/less/redash/query.less
Lines 211 to 214 in a16f551
This code intends that embed visualizations should be flex for vertical.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Before fix. Not flex version
After fix. Flex version