Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed visualizations become flex. #4422

Merged
merged 3 commits into from
Jul 16, 2023
Merged

Conversation

dairyo
Copy link
Contributor

@dairyo dairyo commented Dec 5, 2019

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Embed visualizations are not flex for vertical but I think they should be flex.
The reason is following less code:

.embed__vis {
display: flex;
flex-flow: column;
}

This code intends that embed visualizations should be flex for vertical.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Before fix. Not flex version

NotFlexEmbed

After fix. Flex version

FlexEmbed

@arikfr
Copy link
Member

arikfr commented Jan 6, 2020

@gabrieldutra does this need any changes following the merge of the React version of the viz embed page?

@gabrieldutra
Copy link
Member

@gabrieldutra does this need any changes following the merge of the React version of the viz embed page?

No, looks like it works post-merge without changes

image

@guidopetri
Copy link
Contributor

@shinsuke-nara , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts?

We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that.

@justinclift
Copy link
Member

The merge conflict looked pretty simple, so I just made a first attempt at resolving it.

Lets see if our CI tests seem happy with things.

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #4422 (d73bc60) into master (d5b821e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4422   +/-   ##
=======================================
  Coverage   59.71%   59.71%           
=======================================
  Files         151      151           
  Lines       12261    12261           
  Branches     1658     1658           
=======================================
  Hits         7322     7322           
  Misses       4733     4733           
  Partials      206      206           

@justinclift
Copy link
Member

justinclift commented Jul 16, 2023

This looks like it was already reviewed when first submitted, so now that it's passing CI we might as well merge it. 😄

@justinclift justinclift merged commit 02d128e into getredash:master Jul 16, 2023
EmilaineBorato pushed a commit to sondautilities/sonda_d4b_redash that referenced this pull request Jul 24, 2023
Co-authored-by: Shinsuke Nara <shinsuke.nara@muraoka-design.com>
Co-authored-by: Justin Clift <justin@postgresql.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants