A few updates post eslint #4425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
approved these changes
Dec 8, 2019
| @@ -86,13 +86,13 @@ function EditParameterSettingsDialog(props) { | |||
|
|
|||
| // fetch query by id | |||
| useEffect(() => { | |||
| const { queryId } = props.parameter; | |||
| const queryId = props.parameter.queryId; | |||
There was a problem hiding this comment.
Is this change needed for eslint to detect the correct value for the dependencies array?
There was a problem hiding this comment.
Yes, using it like this it automatically corrects to [props.parameter.queryId]
3 tasks
|
@kravets-levko ath else you think it's important here? |
kravets-levko
approved these changes
Dec 9, 2019
arikfr
added a commit
that referenced
this pull request
Dec 11, 2019
* Remove app/service/query-string (unused) and its dependency. * Fix usage of mixed operators. * eslint --fix fixes for missing dependencies for react hooks * Fix: useCallback dependency passed to $http's .catch. * Satisfy react/no-direct-mutation-state. * Fix no-mixed-operators violations. * Move the decision of whether to render Custom chart one level up to make sure hooks are called in the same order. * Fix: name was undefined. It wasn't detected before because there is such global. * Simplify eslint config and switch to creat-react-app's eslint base. * Add prettier config. * Make sure eslint doesn't conflict with prettier * A few updates post eslint (#4425) * Prettier command in package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
@arikfr here are a few updates I had in mind (was quicker to share in a PR than in comments). The ones @kravets-levko mentioned I'm not so sure about, so will confirm them first.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)