Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Query page to React: Query View #4455

Merged
merged 25 commits into from
Dec 29, 2019
Merged

Migrate Query page to React: Query View #4455

Changes from 2 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
45e958b
Query View updates
gabrieldutra Dec 17, 2019
caf6cd8
Merge branch 'migrate-query-source-view-to-react' into migrate-query-…
gabrieldutra Dec 17, 2019
5be69ab
Update document title
gabrieldutra Dec 17, 2019
b318b16
Fix New Visualization
gabrieldutra Dec 17, 2019
a59f1ce
Merge branch 'migrate-query-source-view-to-react' into migrate-query-…
gabrieldutra Dec 18, 2019
0c468b8
Update QueryView with useQueryResults status
gabrieldutra Dec 18, 2019
c45095b
Merge branch 'migrate-query-source-view-to-react' into migrate-query-…
gabrieldutra Dec 20, 2019
40310f1
Add QueryView actions and separate query properties
gabrieldutra Dec 20, 2019
e8aa293
Fix showEmbedDialog
gabrieldutra Dec 22, 2019
9618a2f
Merge branch 'migrate-query-source-view-to-react' into migrate-query-…
gabrieldutra Dec 24, 2019
e154a00
Prettier QueryView
gabrieldutra Dec 24, 2019
7914602
Add Query status and check queryResults
gabrieldutra Dec 24, 2019
2430947
Merge branch 'migrate-query-source-view-to-react' into migrate-query-…
gabrieldutra Dec 26, 2019
f208b0e
Updates to Schedule
gabrieldutra Dec 26, 2019
acb0772
Use QueryMetadata in the View page
gabrieldutra Dec 26, 2019
9de7d65
Merge branch 'migrate-query-source-view-to-react' into migrate-query-…
gabrieldutra Dec 26, 2019
08fef44
Add editorProps
gabrieldutra Dec 26, 2019
8ba53dc
Merge branch 'migrate-query-source-view-to-react' into migrate-query-…
gabrieldutra Dec 26, 2019
7bbba78
Add cancelExecution
gabrieldutra Dec 26, 2019
efbd7cb
Merge branch 'migrate-query-source-view-to-react' into migrate-query-…
gabrieldutra Dec 28, 2019
f22d8e2
Add shortcut for Query Execution
gabrieldutra Dec 28, 2019
f39cd7d
Remove query-view.less
gabrieldutra Dec 29, 2019
2b1c672
Merge branch 'migrate-query-source-view-to-react' into migrate-query-…
gabrieldutra Dec 29, 2019
3f6d887
Move query execution status block to card
kravets-levko Dec 29, 2019
c52bd2c
Extract QueryView Execute button to a component and fix tooltip issues
kravets-levko Dec 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/app/pages/queries/QueryView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,10 @@ function QueryView(props) {
value={query.description}
isEditable={query.can_edit}
onDone={description => updateQueryDescription(query, description).then(setQuery)}
editor="textarea"
placeholder="Add description"
ignoreBlanks={false}
editorProps={{ autosize: { minRows: 2, maxRows: 4 } }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly what I had in mind 👍

multiline
/>
<Divider />
<QueryMetadata
Expand Down