Added SAML authentication support, eg for OneLogin or Okta #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| show_google_openid=settings.GOOGLE_OAUTH_ENABLED) | ||
|
|
||
| show_google_openid=settings.GOOGLE_OAUTH_ENABLED, | ||
| show_saml_login=settings.SAML_LOGIN_ENABLED) |
There was a problem hiding this comment.
You set this flag, but I don't see you're using it. Not implemented yet, or just a missing file in the pull request?
There was a problem hiding this comment.
Good point. I didn't include the section in login.html to redirect to the saml login page. I've just updated the PR.
|
Thanks, this is really great and appreciated! I have a few comments, but should be good to merge soon. |
arikfr
added a commit
that referenced
this pull request
Jun 30, 2015
Added SAML authentication support, eg for OneLogin or Okta
|
Merged. Thanks! |
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Added SAML authentication support, eg for OneLogin or Okta
pcrane
added a commit
to diffblue/redash
that referenced
this pull request
Oct 3, 2022
According to their website (https://www.pycrypto.org) it's no longer maintained. There are some critical vulnerabilities that aren't going to be addressed. Looking at the history of this change it was introduced 7 years ago as part of getredash#461 and hasn’t been touched since then. I can’t see where it’s being used in that PR, nor can I see where it’s being used in the original gist where the author of the PR got the example code from. Avoids CVE-2013-7459
|
This is not related to the Pull Request directly, but I assume that the author or followers might have SAML enabled for their deployment and should be aware of the following Security Advisory: #5961. This affects all Redash versions and should be patched immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added SAML support as an alternative to Google Apps authentication, eg for OneLogin or Okta.
It adds the REDASH_SAML_METADATA_URL config value which needs to point to the SAML provider metadata url, eg https://app.onelogin.com/saml/metadata/
And an optional REDASH_SAML_CALLBACK_SERVER_NAME which contains the server name of the redash server for the callbacks from the SAML provider (eg demo.redash.io)
On the SAML provider side, example configuration for OneLogin is:
SAML Consumer URL: http://demo.redash.io/saml/login
SAML Audience: http://demo.redash.io/saml/callback
SAML Recipient: http://demo.redash.io/saml/callback
with parameters FirstName and LastName, both configured to be included in the SAML assertion.