Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Add Widget always shows recent queries list #4658

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Conversation

gabrieldutra
Copy link
Member

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Seems it was introduced in #4423 with the change to useSearchResults (there was some logic to set results to null when a query was selected). Added it in here when the term is null.

Related Tickets & Documents

Fixes #4656.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

fix-add-widget

@gabrieldutra gabrieldutra self-assigned this Feb 18, 2020
Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gabrieldutra gabrieldutra merged commit 2833bb5 into master Feb 18, 2020
@gabrieldutra gabrieldutra deleted the fix-add-widget branch February 18, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Widget: always shows recent queries list, even after selection
2 participants