Feature: Map visualization (using Leaflet)

[BrunoSalerno]

@arikfr I open the PR.
This is a map visualization that uses leaflet. Right now only supports point features. You can select the coordinates columns, and draw the points using markers or colored circles.
Each feature has a popup that shows all the 'columns' of the row.

btw: I didn't know what to do with the size of the main div inside the template map.html

(Closes #39)

[landscape-bot]

Repository health increased by 0.15% when pulling b913ce6 on BrunoSalerno:leaflet-visualization into 9cdc2cb on EverythingMe:master.

• No new problems were introduced.
• 5 problems were fixed (including 0 errors and 3 code smells).

[arikfr]

Can it inherit width from the containing element? So the user can control the width like he can for the other widgets.

As for height, maybe change this to be a visualization property (with some default value)?

[arikfr]

This is really great. Let's get the width/height sorted, and merge :)

[BrunoSalerno]

@arikfr great! I'm working on it

[BrunoSalerno]

@arikfr done. I couldn't use VisualizationProvider.defaultOptions. Is it alright this way or there is a specific way to use defaultOptions?

[landscape-bot]

Repository health increased by 0.15% when pulling d7fb2d7 on BrunoSalerno:leaflet-visualization into 9cdc2cb on EverythingMe:master.

• No new problems were introduced.
• 5 problems were fixed (including 0 errors and 3 code smells).

[arikfr]

@BrunoSalerno what do you mean you couldn't use them?

[arikfr]

You don't need jQuery here, you can just change the template to:

<div style='margin:1%;width:95%;height:{{visualization.options.height}}px;'></div>

[arikfr]

I've played around with your branch a little, and noticed that when height is being changed this way (dynamically), it's better to have the map in an inner div. So the template becomes:

<div style='margin:1%;width:95%;height:{{visualization.options.height}}px;'>
    <div style="width:100%; height:100%;"></div>
</div>

And line 138 changes to: $scope.map = L.map(elm[0].children[0].children[0]);.

And you need to add watch for height:

              $scope.$watch('visualization.options.height', function() {

                  $scope.map.invalidateSize(false);
                  setBounds();

              });

[BrunoSalerno]

@arikfr I set defaultOptions in VisualizationProvider, so I expect them to be set in $scope.visualization.options, but they are not. Am I missing something?

[arikfr]

Better to have here type="number" (then it's being saved as number, and you can control the value with arrows).

[arikfr]

@BrunoSalerno re. defaultOptions, looks like it works only for the default visualization type. I'll fix it an update your code to use it.

[BrunoSalerno]

@arikfr nice. I'm pushing the changes and adding a FIXME in the editor directive (in the height part)

[arikfr]

👍

[landscape-bot]

Repository health increased by 0.15% when pulling b743cce on BrunoSalerno:leaflet-visualization into 9cdc2cb on EverythingMe:master.

• No new problems were introduced.
• 5 problems were fixed (including 0 errors and 3 code smells).