Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: visualizations API fixes #468

Merged
merged 3 commits into from
Jul 2, 2015
Merged

Fix: visualizations API fixes #468

merged 3 commits into from
Jul 2, 2015

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Jul 2, 2015

  • Apply default options when changing visualization type.
  • Change title to new when changing visualization type.

arikfr added a commit that referenced this pull request Jul 2, 2015
@arikfr arikfr merged commit 2dab35b into master Jul 2, 2015
@arikfr
Copy link
Member Author

arikfr commented Jul 2, 2015

@BrunoSalerno this includes the fix for defaultOptions.

@BrunoSalerno
Copy link
Contributor

@arikfr great!

@arikfr
Copy link
Member Author

arikfr commented Jul 2, 2015

@BrunoSalerno this introduced a small bug, but fixed it already in another PR :) so should be safe for you to upgrade.

Btw, are you on Twitter? I want to tweet about this an mention you.

@BrunoSalerno
Copy link
Contributor

@arikfr ahh, nice ;) I hadn't upgraded to the last version.
My twitter account is @SalernoBr.
BTW, I'm preparing a heatmap mode for the Map visualization. In a couple of days I'll send you the PR.

@arikfr
Copy link
Member Author

arikfr commented Jul 4, 2015

@BrunoSalerno heatmaps will be great addition! looking forward :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants