Visualization Editor: consistent styles for control labels #4686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually prefer it with |
|
Hm 🤔 For me it looks wrong if some labels have normal font weight and others are bolder (especially when there are both types on the same form). So what you suggest? Make all labels bolder? normal? keep everything as is? |
|
The mental model I have: the non checkbox labels are more like titles while the label for a checkbox is more like regular text. Hence why one is bold and the other isn't. I vote for keeping as is. |
|
As we don't have a consensus here I'm closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Before/After (checkbox labels):