Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use npm ci instead of npm install in CI scripts #4688

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Use npm ci instead of npm install in CI scripts #4688

merged 2 commits into from
Feb 26, 2020

Conversation

kravets-levko
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Other

Description

npm install may install newer versions of packages, while npm ci will perfectly restore dependencies using package-lock.json. Using npm ci is recommended for CI scripts

@kravets-levko kravets-levko self-assigned this Feb 26, 2020
@kravets-levko kravets-levko merged commit 7043951 into master Feb 26, 2020
@kravets-levko kravets-levko deleted the npm-ci branch February 26, 2020 17:23
@weekly-digest weekly-digest bot mentioned this pull request Mar 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr arikfr approved these changes

@gabrieldutra gabrieldutra Awaiting requested review from gabrieldutra

Assignees

@kravets-levko kravets-levko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kravets-levko @arikfr