Cancel BigQuery Queries #4701
Merged
Cancel BigQuery Queries #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Mar 4, 2020
redash/query_runner/big_query.py
Outdated
| if self.current_job_id: | ||
| response_kind = None | ||
| while response_kind != "bigquery#jobCancelResponse": | ||
| response_kind = jobs.cancel( |
There was a problem hiding this comment.
We need to repeatedly execute the cancel request to get its status? No way to just get status after the first request?
There was a problem hiding this comment.
This bothered me as well. Turns out the client is executing previous requests when calling execute() in the cancellation block (the result kind is a getQueryResultResponse for a call to /cancel 🤨), so I'm guessing it's either some sort of optimization or a bug. Tried drilling into their source code to see if this is intentional, and if there's a flush method of some sort. Eventually gave up and realized it'll be easier to instantiate a new client. See 893c427.
arikfr
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When a user requests to cancel a BigQuery query, or when the Redash time limit is reached, the underlying job in BigQuery continues to run until completion. This PR cancels the underlying BigQuery job in these situations.
Related Tickets & Documents
#4681