Don't immediately remove notifications from notification trays #4773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the notifications go into browser/OS notification trays so users can click on them from there if they miss the initial notification. Modern browsers generally use OS notifications so the user is in control of the notification at the OS level.
|
The percy UI change seems to be a false-positive. |
|
What's the default behavior without the user adjusting the settings? Will the notification just remain visible until dismissed? |
|
No, every OS dismisses the notification from the screen after a delay by default.
|
|
Years ago Chrome didn't use the native notifications and they had them linger around indefinitely but they changed that behaviour as it didn't match any other browser and was a poor UX. There is a separate flag on notifications to request they stay around forever. |
|
Thanks! |
mnoorenberghe
added a commit
to mnoorenberghe/redash
that referenced
this pull request
Apr 17, 2020
…dash#4773) Let the notifications go into browser/OS notification trays so users can click on them from there if they miss the initial notification. Modern browsers generally use OS notifications so the user is in control of the notification at the OS level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Let the notifications go into browser/OS notification trays so users can click on them from there if they miss the initial notification. Modern browsers generally use OS notifications so the user is in control of the notification at the OS level.
Example of how users can adjust the timeout on macOS
The current 3s delay is almost unusuable… I can rarely get my mouse to that part of the screen in time.