-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Helper Classes from visualizations #4788
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4c1b700
Remove external refs from visualization less files
gabrieldutra 99da686
Remove Helper Classes from ContextHelp
gabrieldutra bcfc530
Remove Helper Classes from Section
gabrieldutra 1fe992f
Remove Helper Classes from Switch
gabrieldutra d687a57
Make all inputs with width: 100% by default
gabrieldutra edef8bf
Remove w-100 from Inputs
gabrieldutra 31f0eea
Replace margin and padding
gabrieldutra b53342d
ColorPicker: Make text-nowrap the default behavior
gabrieldutra 8d62f19
Remove Helper classes from cloropleth Legend
gabrieldutra 071159e
Remove d-flex from visualizations
gabrieldutra 1a759b4
Remove text-nowrap from visualizations
gabrieldutra 12fe55a
Fix padding for Tabs on blank project
gabrieldutra a585f86
Merge branch 'master' into visualizations-css-deps
gabrieldutra 2de2b05
Merge branch 'master' into visualizations-css-deps
gabrieldutra 4892984
Remove external deps from json-view-interactive
gabrieldutra 2009b66
Add variables file for visualizations
gabrieldutra 32dedf9
Merge branch 'master' into visualizations-css-deps
gabrieldutra e1c4cc3
Revert "Fix padding for Tabs on blank project"
gabrieldutra 069fd27
Rename redash -> visualizations
gabrieldutra ceb2390
Merge branch 'master' into visualizations-css-deps
gabrieldutra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,3 +38,7 @@ | |
.color-picker-trigger { | ||
cursor: pointer; | ||
} | ||
|
||
.color-picker-wrapper { | ||
white-space: nowrap; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
.visualization-editor-section-title { | ||
margin-top: 0px; | ||
margin-bottom: 15px; | ||
} | ||
|
||
.visualization-editor-section { | ||
margin-bottom: 15px; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
.switch-with-label { | ||
display: flex; | ||
align-items: center; | ||
|
||
.switch-text { | ||
margin-left: 10px; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import React from "react"; | ||
import cx from "classnames"; | ||
import AntInput from "antd/lib/input"; | ||
import withControlLabel from "./withControlLabel"; | ||
|
||
import "./TextArea.less"; | ||
|
||
function TextArea({ className, ...otherProps }) { | ||
return <AntInput.TextArea className={cx("visualization-editor-text-area", className)} {...otherProps} />; | ||
} | ||
|
||
export default withControlLabel(TextArea); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.visualization-editor-text-area { | ||
resize: vertical; | ||
} |
15 changes: 10 additions & 5 deletions
15
client/app/components/visualizations/editor/context-help.less
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,17 @@ | ||
@import (reference, less) '~@/assets/less/main.less'; | ||
|
||
a.visualization-editor-context-help { | ||
&, .ant-typography & { | ||
&, | ||
.ant-typography & { | ||
font: inherit; | ||
color: inherit; | ||
|
||
&:hover, &:active { | ||
color: @link-hover-color; | ||
&:hover, | ||
&:active { | ||
color: #0a6ebd; | ||
} | ||
} | ||
} | ||
|
||
.context-help-default-icon { | ||
margin-left: 5px; | ||
margin-right: 5px; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,3 +5,7 @@ | |
} | ||
} | ||
} | ||
|
||
.visualization-editor-input { | ||
width: 100% !important; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forced all inputs to have
width: 100%
to remove thew-100
classes (all the InputNumbers and Select's had this class). LMK if you see any isolated case as I didn't find any on my checks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no special cases, as far as I remember all editor inputs should have
width: 100%
and we use grid where needed