Visualizations customizable settings #4793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldutra
force-pushed
the
separate-visualization-components
branch
from
77c0877 to
7335d45
Compare
gabrieldutra
force-pushed
the
separate-visualization-components
branch
from
7335d45 to
be8666a
Compare
arikfr
reviewed
Apr 13, 2020
gabrieldutra
commented
Apr 14, 2020
| @@ -42,12 +43,17 @@ export default function VisualizationRenderer(props) { | |||
| setFilters(combineFilters(filtersRef.current, props.filters)); | |||
| }, [props.filters]); | |||
|
|
|||
| const cleanColumnNames = useMemo( | |||
| () => map(data.columns, col => ({ ...col, name: getColumnCleanName(col.friendly_name) })), | |||
There was a problem hiding this comment.
@kravets-levko it seemed to make sense to move getColumnCleanName out of Table vis and rather apply it to all visualizations, do you see any problems may happen with this change? (that method is used to remove ::filter from column names for example)
gabrieldutra
commented
Apr 15, 2020
Comment on lines
+15
to
+24
| choroplethAvailableMaps: { | ||
| countries: { | ||
| name: "Countries", | ||
| url: countriesDataUrl, | ||
| }, | ||
| subdiv_japan: { | ||
| name: "Japan/Prefectures", | ||
| url: subdivJapanDataUrl, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I tried to go in the direction of #4599 as it has a complementary code to this.
gabrieldutra
commented
Apr 15, 2020
| @@ -1,25 +1,16 @@ | |||
| import { omit, merge } from "lodash"; | |||
| import { omit, merge, get } from "lodash"; | |||
| import axios from "axios"; | |||
There was a problem hiding this comment.
No reason to add a service axios dependency instead of using the base one.
arikfr
approved these changes
Apr 25, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Reorganize visualization components folder
Components related to Redash app were removed from
visualizations/componentsfolder (EditVisualizationDialog and VisualizationRenderer). Also created a general Renderer and Editor that takes thetypeand select it from the list.Add customizable settings
Creates a mutable object with options (currently only one from the HelpTrigger, soon others from clientConfig options).
Update HelpTrigger
HelpTrigger now alternatively receives a link and a title in replacement for the type constant. Also it renders a regular
<a>when link is not inside redash.io (adds an External icon in such case).clientConfig options
Were all put into visualization settings.
Related Tickets & Documents
--
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
--