Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce number of queries used to load the dashboards list #4816

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Reduce number of queries used to load the dashboards list #4816

merged 3 commits into from
Apr 21, 2020

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Apr 20, 2020

What type of PR is this? (check all applicable)

  • Refactor

Description

Reduced the number of queries used to load dashboards list:

  1. Make sure all required user object fields are loaded in first query (otherwise number of fields X number of dashboards is issued 😱).
  2. Use a single query to load favorites status for all the dashboards together.

Related Tickets & Documents

#4804

@arikfr arikfr merged commit cfc8215 into master Apr 21, 2020
@arikfr arikfr deleted the dash-perf branch April 21, 2020 07:07
@weekly-digest weekly-digest bot mentioned this pull request Apr 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arikfr