Return cached data source schema when available #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldutra
commented
Jun 1, 2020
| } | ||
|
|
||
| function getSchema(dataSource, refresh = undefined) { | ||
| if (!dataSource) { | ||
| return Promise.resolve([]); | ||
| } | ||
|
|
||
| const fetchSchemaFromJob = (data) => { | ||
| return sleep(1000).then(() => { |
There was a problem hiding this comment.
I also removed the first request sleeping time, from a few tests a good portion of the results would be done already in the first request without the sleeping time
arikfr
approved these changes
Jun 2, 2020
|
Nice, you can indeed see the improvement even without the backend changes. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR updates the Data Source schema handler to immediately return cached results when they are available.
Related Tickets & Documents
This is a follow up for #4797
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
--