Feature: Support Impala as DataSource #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| try: | ||
| from impala.dbapi import connect | ||
| from dateutil import parser |
There was a problem hiding this comment.
no need to have dateutil in a try/except block.
|
|
||
| if error is not None: | ||
| raise Exception("Failed getting schema.") | ||
| return json.loads(results)['rows'] |
There was a problem hiding this comment.
Just add to run_query another parameter (json_result) with default of True, and when it's False don't do json.dumps and return data as is. I wanted to implement something like this for all connectors. Maybe even do the json.dumps in a layer above.
If you still prefer to keep this method, give it a more describing name and make it "protected".
There was a problem hiding this comment.
for now I'll keep it the same (protecting + different name)
will implement your suggestion in next pull req :-)
arikfr
added a commit
that referenced
this pull request
Jul 22, 2015
Feature: Support Impala as DataSource
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Feature: Support Impala as DataSource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial support for Cloudera Impala.
http://www.cloudera.com/content/cloudera/en/products-and-services/cdh/impala.html
CDH version 5.2 and above.
python connector via https://github.com/cloudera/impyla