Add React hot refresh and refine viz lib build #5104
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
I was developing visualization editors in the dialog and was annoyed by automatic whole page refreshes and losing my opened dialog. So I decided to fix it and adding support for hot refresh!
The recently released react-refresh-webpack-plugin is amazing and actually very easy to setup, with some caveats that took me a couple of hours to debug.
To enable hot refresh, some additional changes had to be made:
.eslintrc
fromclient
to the root directory, so it can apply toviz-lib
, too. (VSCode ESLint check will fail inviz-lib
because of missing.eslintrc
)viz-lib
from@
to@@
, so it doesn't conflict withclient/app
. This is both a requirement of the aforementioned change and for reducing confusionsviz-lib
Related Tickets & Documents
#4837
Mobile & Desktop Screenshots/Recordings (if there are UI changes)