Move datasource requirements from bootstrap to own requirements file #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
added a commit
that referenced
this pull request
Jul 27, 2015
Move datasource requirements from bootstrap to own requirements file
|
Totally makes sense and having the versions defined is a good move. I'm curious now -- why is it making a difference for you? |
|
Thanks! (There are a few more requests like this still to come.) |
|
Nice. I guess that once #450 (Docker support) is implemented, it will make your life easier... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nicer for us if the requirements for new datasources were separated from bootstrapping of an instance. Would you mind having a change like this?