Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added clear button for query-based parameter inputs #5710

Merged
merged 3 commits into from
Jul 3, 2022

Conversation

adamzwakk
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Added a clear button to these multi-select inputs, its handy to clear everything at once rather than 'backspace' through possibly dozens of values to reset the input.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

image

Copy link
Contributor

@susodapop susodapop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge usability win!

Thanks 🚀

@susodapop
Copy link
Contributor

Before merging quick question: can this be implemented for ordinary (non query-backed) dropdown inputs also?

@adamzwakk
Copy link
Contributor Author

For sure, I'll get those done today/this week

@adamzwakk
Copy link
Contributor Author

Added to every dropdown that has a scroll (AntdSelect)

@susodapop susodapop added the Team Review Meets PR criteria, ready for full review label Mar 3, 2022
@susodapop susodapop merged commit 173cbdb into getredash:master Jul 3, 2022
AkaashK pushed a commit to tharzeez/redash that referenced this pull request Jul 18, 2023
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Meets PR criteria, ready for full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants