fix MySQL multi statement support #5957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xing MySQL multi statement support
AkaashK
pushed a commit
to tharzeez/redash
that referenced
this pull request
Jul 18, 2023
…xing MySQL multi statement support (getredash#5957)
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
…xing MySQL multi statement support (getredash#5957)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump
mysqlclientfrom1.3.14to2.1.1,memsqlfrom3.0.0to3.2.0to fix MySQL multi statement support.What type of PR is this?
Description
The version string returned from
_mysql.get_client_info()is different, and is lower than 4 in the latest Docker image.It maybe due to Maridb client connector changed their version number naming policy.
The new version of
mysqlclientno longer check client version number to enableMULTI_STATEMENTSandMULTI_RESULTSflags. So updatingmysqlclientto a newer version could fix the issue.memsqlalso need to be updated to be compatible with new version of mysqlclient.How is this tested?
Related Tickets & Documents
Fixes #5925.