Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix worker error in macOS #6224

Merged
merged 7 commits into from
Jul 21, 2023
Merged

Fix worker error in macOS #6224

merged 7 commits into from
Jul 21, 2023

Conversation

gaecoli
Copy link
Member

@gaecoli gaecoli commented Jul 21, 2023

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@gaecoli
Copy link
Member Author

gaecoli commented Jul 21, 2023

Like this? @justinclift

@justinclift
Copy link
Member

justinclift commented Jul 21, 2023

Yeah, this looks like it will work. You'll need to fix the conflict that GitHub is showing though.

I've just changed the title of this PR to be a bit better too. 😄

gaecoli and others added 3 commits July 21, 2023 18:20
# Conflicts:
#	redash/tasks/worker.py
# Conflicts:
#	redash/tasks/worker.py
@justinclift justinclift changed the title Temp1 Fix worker error in macOS Jul 21, 2023
gaecoli added 2 commits July 21, 2023 18:24
# Conflicts:
#	redash/tasks/worker.py
@gaecoli
Copy link
Member Author

gaecoli commented Jul 21, 2023

@justinclift fine

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #6224 (3242659) into master (c8eb445) will not change coverage.
The diff coverage is 71.42%.

@@           Coverage Diff           @@
##           master    #6224   +/-   ##
=======================================
  Coverage   59.99%   59.99%           
=======================================
  Files         152      152           
  Lines       12443    12448    +5     
  Branches     1686     1687    +1     
=======================================
+ Hits         7465     7468    +3     
- Misses       4770     4771    +1     
- Partials      208      209    +1     
Impacted Files Coverage Δ
redash/tasks/worker.py 65.93% <71.42%> (-0.35%) ⬇️

@justinclift justinclift merged commit 8376e41 into master Jul 21, 2023
@justinclift justinclift deleted the temp1 branch July 21, 2023 11:10
EmilaineBorato pushed a commit to sondautilities/sonda_d4b_redash that referenced this pull request Jul 24, 2023
* Update worker.py
* fix
---------

Co-authored-by: rajat goyal <gyl.rajat@gmail.com>
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
* Update worker.py
* fix
---------

Co-authored-by: rajat goyal <gyl.rajat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants