Fix the broken icon loading #6340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The icons haven't been loading properly since PR 6295, due to an incompatibility with some other outdated dependencies. This updates those other dependencies to fix the problem.
Codecov Report
@@ Coverage Diff @@
## master #6340 +/- ##
=======================================
Coverage 60.74% 60.74%
=======================================
Files 153 153
Lines 12513 12513
Branches 1695 1695
=======================================
Hits 7601 7601
Misses 4686 4686
Partials 226 226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
The icons haven't been loading properly since PR #6295, due to an incompatibility with some other outdated dependencies. This PR updates those other dependencies, fixing the problem.
How is this tested?
Tested by performing
yarn && make buildwith a previously built backend then looking at the icons in a browser.Neither unit tests nor Cypress testing have been done yet. So, lets see if CI says things are ok. 😄