Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Python 3.8-3.10 #6445

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Accept Python 3.8-3.10 #6445

merged 1 commit into from
Sep 11, 2023

Conversation

eradman
Copy link
Collaborator

@eradman eradman commented Sep 11, 2023

For running a development environment on Ubuntu 22

What type of PR is this?

  • Upgrade

How is this tested?

  • Unit tests (pytest, jest)
  • Manually

For running a development environment on Ubuntu 22
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #6445 (b90c4e7) into master (ca90076) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6445   +/-   ##
=======================================
  Coverage   60.98%   60.98%           
=======================================
  Files         157      157           
  Lines       12815    12815           
  Branches     1741     1741           
=======================================
  Hits         7815     7815           
  Misses       4764     4764           
  Partials      236      236           

@eradman eradman merged commit b4e4a5a into getredash:master Sep 11, 2023
@eradman eradman deleted the ubuntu22 branch September 11, 2023 19:26
@guidopetri
Copy link
Contributor

FYI - when we update the pyproject.toml we also have to run poetry lock and commit the changes in poetry.lock, otherwise they get out of sync

@eradman
Copy link
Collaborator Author

eradman commented Sep 12, 2023

Thanks for pointing this out @guidopetri. poetry lock seems to have updated too much. I'll submit another PR with the changes that poetry update requires-python makes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants