Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL Support #69

Merged
merged 9 commits into from
Jan 30, 2014
Merged

MySQL Support #69

merged 9 commits into from
Jan 30, 2014

Conversation

ekampf
Copy link
Contributor

@ekampf ekampf commented Jan 29, 2014

No description provided.

@ekampf
Copy link
Contributor Author

ekampf commented Jan 29, 2014

Still need to figure out the connection_string thing in the query runner

@arikfr
Copy link
Member

arikfr commented Jan 30, 2014

@ekampf can you add requirements_mysql.txt file that has the needed packages for MySQL?

import sys
import select
from .utils import JSONEncoder


def redshift(connection_string):
def mysql(connection_string):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You kept the mysql one here, but moved the redshift one to mysql_query_runner.py...

@ekampf
Copy link
Contributor Author

ekampf commented Jan 30, 2014

MySQLdb isn't available via pip.
Want me to add the install instructions to the README?

Download package from http://sourceforge.net/projects/mysql-python

$ gunzip MySQL-python-1.2.3.tar.gz
$ tar -xvf MySQL-python-1.2.3.tar
$ cd MySQL-python-1.2.3
$ python setup.py build
$ python setup.py install

arikfr added a commit that referenced this pull request Jan 30, 2014
@arikfr arikfr merged commit 5eddddb into getredash:master Jan 30, 2014
@ekampf ekampf deleted the feature/mysql branch April 1, 2014 11:48
christophervalles pushed a commit to hailocab/redash that referenced this pull request May 8, 2014
washort pushed a commit to washort/redash that referenced this pull request Dec 13, 2017
washort pushed a commit to washort/redash that referenced this pull request Dec 13, 2017
washort pushed a commit to washort/redash that referenced this pull request Jan 8, 2018
washort pushed a commit to washort/redash that referenced this pull request Jan 9, 2018
washort pushed a commit to washort/redash that referenced this pull request Jan 9, 2018
engeenity pushed a commit to engeenity/redash that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants