-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed error serialization #6937
Fixed error serialization #6937
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6937 +/- ##
==========================================
+ Coverage 63.80% 63.83% +0.03%
==========================================
Files 161 161
Lines 13087 13094 +7
Branches 1812 1814 +2
==========================================
+ Hits 8350 8359 +9
+ Misses 4434 4432 -2
Partials 303 303
|
6d0075e
to
9d4b241
Compare
This change seems to resolve the problem. As codecov is highlighting, we should add some tests for this updated code path. |
9d4b241
to
121f2ef
Compare
added tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that the tests fail if this fix is removed. All good
21ff4b7
to
26cc1b9
Compare
What type of PR is this?
Fixes #6936
Description
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)