Add new text pattern parameter #7025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eradman
reviewed
Jul 23, 2024
ezraodio1
force-pushed
the
text-regex-option
branch
from
07b2971 to
142b872
Compare
eradman
approved these changes
Jul 24, 2024
"No more"? |
Ah yes, all seems to work well. The previous revision received two 👍 so I also take that as a vote of confidence for the design. |
|
Cool, all good. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
This PR adds in a new "Text Pattern" parameter input type. This input type allows a creator to specify a regex pattern, and the query will only run if the input matches the regex pattern. Since this parameter input type is not "Text," users can share dashboards that have this parameter input type, therefore addressing (#6785).
How is this tested?
Related Tickets & Documents
(#6785)
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Screen.Recording.2024-06-19.at.3.51.08.PM.mov