Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Evaluate button for alerts to test them #7032

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

ezraodio1
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Adding new button to evaluate an alert and test its condition. This button allows users to verify that the alert they created works how they intended it to. This PR is related to #7024.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

(#7024)

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Screen.Recording.2024-06-25.at.12.30.11.PM.mov

client/app/pages/alert/Alert.jsx Outdated Show resolved Hide resolved
client/app/pages/alert/Alert.jsx Outdated Show resolved Hide resolved
@eradman eradman enabled auto-merge (squash) August 1, 2024 14:31
Copy link
Collaborator

@eradman eradman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super useful. Works as expected

@eradman
Copy link
Collaborator

eradman commented Aug 1, 2024

@ezraodio1 after rebasing it appears that there is one restyled change that needs to be applied

@eradman eradman merged commit 660d04b into getredash:master Aug 1, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants