Remove defaults set during schema upgrade/downgrade #7068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezraodio1
force-pushed
the
schema-upgrade-downgrade
branch
from
0f90632 to
f804345
Compare
ezraodio1
force-pushed
the
schema-upgrade-downgrade
branch
from
f804345 to
b982292
Compare
eradman
approved these changes
Jul 18, 2024
|
@ezraodio1 This is pretty awesome, thanks for getting that problem fixed. 😄 |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
This PR addresses #6836. The fix removes the defaults that are set during schema upgrade/downgrade.
It looks like defaults are set in redash/models/init.py, but it seems like they never actually make it to the database. This could be due to how setting the default parameter works in SQLAlchemy.
How is this tested?
Ran
./manage.py db downgrade fd4fc850d7eaand then./manage.py db upgradejust like @wlach did in #6836. The upgrade and downgrade seem to work correctly after making the fix.Related Tickets & Documents
#6836
Mobile & Desktop Screenshots/Recordings (if there are UI changes)