Alert evaluation bugfix + add average selector to alerts #7098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eradman
requested changes
Aug 1, 2024
ezraodio1
force-pushed
the
alert-average-selector
branch
2 times, most recently
from
406cbe6 to
704b7d8
Compare
ezraodio1
changed the title
eradman
reviewed
Aug 1, 2024
Restyled by prettier Evaluate alerts as unknown when you cannot evaluate min, max or avg
ezraodio1
force-pushed
the
alert-average-selector
branch
from
704b7d8 to
fbb447e
Compare
eradman
requested changes
Aug 2, 2024
There was a problem hiding this comment.
@ezraodio1 can you submit the bug fixes as a separate PR? I may not be able to review this feature for another week or so
Done. The bug fix part is in #7103. Once that fix is implemented, I'll change this PR so that it only adds the ability to calculate the average. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
This is an addition to #7076. This PR adds the ability to select the average value from a column when making an alert.
This PR also makes the alert evaluate to UNKNOWN when min, max, or avg cannot be computed for a column. For example, this will happen when the column data type is a string, and those strings can't be converted to numbers.
This PR also deletes a print statement that was accidentally left in #7076.
How is this tested?
Related Tickets & Documents
#7076
Mobile & Desktop Screenshots/Recordings (if there are UI changes)