Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate autocorrect to QMK Core? #4

Closed
drashna opened this issue Dec 31, 2021 · 3 comments
Closed

Migrate autocorrect to QMK Core? #4

drashna opened this issue Dec 31, 2021 · 3 comments

Comments

@drashna
Copy link
Contributor

drashna commented Dec 31, 2021

Would you be opposed if I migrated the code into QMK core?
It's a very useful feature, and I think that many more people would benefit from it. Also, the python can be integrated into the qmk utility.
@getreuer
Copy link
Owner

getreuer commented Jan 1, 2022

Awesome, migrating into QMK core would be great. My only concern is license. Would this migration be possible with the current Apache license? The code is Google-owned, and they prefer to open source with Apache license. Let me know if that would work.

Other than that, I am fully in support! Thanks for suggesting this.

@drashna
Copy link
Contributor Author

drashna commented Jan 2, 2022

QMK uses gpl2+ specifically, which is compatible with apache sub-licensing. So it's definitely allowable.

Also, with help, I have been able to migrate the database generation code into qmk-cli (as that is already python).

I've opened a PR for qmk firmware, and you can take a look at it over here:
qmk/qmk_firmware#15699

@getreuer
Copy link
Owner

getreuer commented Jan 2, 2022

Fantastic! Really cool to see how you weave it into QMK. I'll make a review pass on your PR.

@drashna drashna closed this as completed Mar 2, 2022
fride added a commit to fride/qmk-keymap that referenced this issue Aug 5, 2024
@fride
Homerows with Archordion (getreuer#4)
3bb8ec4 
* home row mods

* home row mods, better than I thought.

* Number layout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drashna @getreuer