Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push nuget nupkg and snupkg together #459

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Push nuget nupkg and snupkg together #459

merged 1 commit into from
Feb 8, 2023

Conversation

mattjohnsonpint
Copy link
Contributor

In #458, I added .snupkg files to the same list of artifacts as .nupkg files. Unfortunately, this didn't work. See getsentry/publish#1857. The issue is that when publishing a .snupkg, nuget will 404 if the corresponding .nupkg has not yet been uploaded.

I though of just sorting the array, but that won't work because we use an array of promises when publishing, which won't guarantee that the first one is complete before the second one starts.

Switching to the original approach I started #458 with: We'll just make sure the .snupkg artifact is downloaded (if there is one), so it will be in the same folder as the .nupkg file. Then dotnet nuget push will automatically see them both when pushing the .nupkg and send the .snupkg only once the .nupkg has successfully been published.

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattjohnsonpint mattjohnsonpint merged commit 29e8619 into master Feb 8, 2023
@mattjohnsonpint mattjohnsonpint deleted the fix/nuget branch February 8, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants