Push nuget nupkg and snupkg together #459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #458, I added
.snupkg
files to the same list of artifacts as.nupkg
files. Unfortunately, this didn't work. See getsentry/publish#1857. The issue is that when publishing a.snupkg
, nuget will 404 if the corresponding.nupkg
has not yet been uploaded.I though of just sorting the array, but that won't work because we use an array of promises when publishing, which won't guarantee that the first one is complete before the second one starts.
Switching to the original approach I started #458 with: We'll just make sure the
.snupkg
artifact is downloaded (if there is one), so it will be in the same folder as the.nupkg
file. Thendotnet nuget push
will automatically see them both when pushing the.nupkg
and send the.snupkg
only once the.nupkg
has successfully been published.