Skip to content

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Oct 1, 2025

@bruno-garcia bruno-garcia requested a review from BYK October 2, 2025 14:08
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the very quick turn around.

Can we also add a comment to the code where we added this behavior as people working on Craft tend not to read the huge readme 😅

Co-authored-by: Burak Yigit Kaya <ben@byk.im>
@bruno-garcia bruno-garcia requested a review from BYK October 2, 2025 18:55
@bruno-garcia
Copy link
Member Author

Can we also add a comment to the code where we added this behavior as people working on Craft tend not to read the huge readme 😅

The diff was only the --skip-duplicate which I'd argue is redundant, so IMO with the README note it's quite clear to anyone touching this in the future, or running it

@bruno-garcia bruno-garcia enabled auto-merge (squash) October 3, 2025 22:51
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the comment myself for future reference as I have no idea what --skip-duplicate would do and wouldn't expect anyone to intuitively understand that if they don't know about NuGet already.

@bruno-garcia bruno-garcia merged commit d2c0239 into master Oct 6, 2025
13 checks passed
@bruno-garcia bruno-garcia deleted the bruno-garcia-patch-1 branch October 6, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants