Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: windows binary versioning #110

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

supervacuus
Copy link
Collaborator

This adds binary versioning of crashpad_handler.exe and crashpad_wer.dll. It depends on sentry-native as the parent project. If it doesn't exist, no version information is added.

I am adding this to getsentry/sentry-native#1076 because it could be convenient to check if the respective binaries come from the same release as the Native SDK client library when using the crashpad backend.

Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supervacuus supervacuus merged commit 8961424 into getsentry Nov 12, 2024
8 checks passed
@supervacuus supervacuus deleted the feat/windows_binary_versioning branch November 12, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants