Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Document valid Span 'op' field #242

Closed
marandaneto opened this issue Jan 15, 2021 · 2 comments
Closed

Document valid Span 'op' field #242

marandaneto opened this issue Jan 15, 2021 · 2 comments
Labels
enhancement New feature or request performance

Comments

@marandaneto
Copy link
Contributor

context: getsentry/sentry-java#1170

@rhcarvalho @HazAT does it make sense to make op an Enum or is it really a plain string? is somewhere documented which ops does our frontend renders nicely? what is used for? etc...

@marandaneto marandaneto added performance enhancement New feature or request labels Jan 15, 2021
@rhcarvalho
Copy link
Contributor

Not an enum, we need this to be free form. Users can define whatever "operation" means for them.

On the other hand, SDKs auto-instrumented spans do use a few "op" values and those we try to keep consistent, like http.server for HTTP servers.

(internal-only, see also https://app.asana.com/0/1143066478782529/1173540715390795/f)

@marandaneto
Copy link
Contributor Author

cool thank you, I'm closing this then.

nothing to be done, just to be sure that we're using http.server for HTTP servers.

cc @Tyrrrz @maciejwalkowiak @brustolin

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request performance
Projects
None yet
Development

No branches or pull requests

2 participants