Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Document default values for 'Span.op' on auto instrumented SDKs #247

Closed
marandaneto opened this issue Jan 20, 2021 · 6 comments
Closed

Document default values for 'Span.op' on auto instrumented SDKs #247

marandaneto opened this issue Jan 20, 2021 · 6 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request performance

Comments

@marandaneto
Copy link
Contributor

http.server for HTTP servers
http.client for HTTP clients

Context: #242
Also getsentry/sentry-java#1165 (comment)

Python does http for HTTP clients
https://github.com/getsentry/sentry-python/blob/ca828c9486f4a0030a744849a4e8e10c5a1c7aeb/sentry_sdk/integrations/stdlib.py#L81

as only http alone is ambiguous, I'd prefer to be more specific.

Let's fix this on Python (and what else?) and write it down on the docs?

@marandaneto
Copy link
Contributor Author

cc @untitaker @rhcarvalho @bruno-garcia

@marandaneto marandaneto added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 20, 2021
@untitaker
Copy link
Member

sgtm

@bruno-garcia
Copy link
Member

bruno-garcia commented Mar 24, 2021

At first I thought it was related to https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md but turns out it's just our on op for Spans.

Makes sense to align like you suggested. That means we're changing python though @ahmedetefy or @rhcarvalho ? To have http.server and http.client ? Possibly other SDKs too.

@rhcarvalho
Copy link
Contributor

rhcarvalho commented Mar 26, 2021

Yes, AFAICT the names were based on old versions of the semantic conventions (same for span statuses).

I'm good with http.server and http.client, don't see a problem with changing this for all SDKs. AFAIK the Sentry UI does not rely on specific names.

@ahmedetefy
Copy link

Sounds good! Opened up a ticket for it https://app.asana.com/0/1159797622087522/1200117075062458

@marandaneto
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request performance
Projects
None yet
Development

No branches or pull requests

5 participants