This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
feat(replay): Add documentation about replay event types #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
cc @vaind |
cmanallen
reviewed
Mar 20, 2024
|
|
||
| **Additional Item Headers:** | ||
|
|
||
| *None* |
There was a problem hiding this comment.
I believe length is required.
There was a problem hiding this comment.
Not for replay_event though right? only replay_recording which is below
There was a problem hiding this comment.
Each envelope item needs a length header because a new line character could be present in the item's payload.
There was a problem hiding this comment.
Hmm we currently do not send a length header for js sdk
vaind
reviewed
Mar 24, 2024
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
cmanallen
approved these changes
Jul 10, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: